Skip to content

Conversation

@MehrazRumman
Copy link
Contributor

@MehrazRumman MehrazRumman commented May 15, 2023

Looks like an oversight !

@auvipy auvipy self-requested a review May 15, 2023 14:56
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat!

@auvipy auvipy added this to the 3.15 milestone May 15, 2023
@auvipy auvipy merged commit 7bebe97 into encode:master May 15, 2023
@auvipy
Copy link
Collaborator

auvipy commented May 15, 2023

thanks for your contribution and welcome aboard!

@MehrazRumman
Copy link
Contributor Author

Thank You .

@DartBond
Copy link

@auvipy do we have some expectations about new tags with Django 4.2 support?

saadullahaleem pushed a commit to saadullahaleem/django-rest-framework that referenced this pull request May 27, 2023
auvipy added a commit that referenced this pull request May 29, 2023
* fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer

* fix formatting issues for list serializer validation fix

* fix imports sorting for list serializer tests

* remove django 2.2 from docs index (#8982)

* Declared Django 4.2 support in README.md (#8985)

* Fix Links in Documentation to Django `reverse` and `reverse_lazy` (#8986)

* Fix Django Docs url in reverse.md

Django URLs of the documentation of `reverse` and `reverse_lazy` were wrong.

* Update reverse.md

* fix URLPathVersioning reverse fallback (#7247)

* fix URLPathVersioning reverse fallback

* add test for URLPathVersioning reverse fallback

* Update tests/test_versioning.py

---------

Co-authored-by: Jorn van Wier <[email protected]>
Co-authored-by: Asif Saif Uddin <[email protected]>

* Make set_value a method within `Serializer` (#8001)

* Make set_value a static method for Serializers

As an alternative to #7671, let the method be overridden if needed. As
the function is only used for serializers, it has a better place in the
Serializer class.

* Set `set_value` as an object (non-static) method

* Add tests for set_value()

These tests follow the examples given in the method.

* fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer

* Make set_value a method within `Serializer` (#8001)

* Make set_value a static method for Serializers

As an alternative to #7671, let the method be overridden if needed. As
the function is only used for serializers, it has a better place in the
Serializer class.

* Set `set_value` as an object (non-static) method

* Add tests for set_value()

These tests follow the examples given in the method.

* fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer

* fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer

* fix formatting issues for list serializer validation fix

* fix: Make the instance variable of child serializer point to the correct list object instead of the entire list when validating ListSerializer

* fix formatting issues for list serializer validation fix

* fix linting

* Update rest_framework/serializers.py

Co-authored-by: Sergei Shishov <[email protected]>

* Update rest_framework/serializers.py

Co-authored-by: Sergei Shishov <[email protected]>

* fix: instance variable in list serializer, remove commented code

---------

Co-authored-by: Mathieu Dupuy <[email protected]>
Co-authored-by: Mehraz Hossain Rumman <[email protected]>
Co-authored-by: Dominik Bruhn <[email protected]>
Co-authored-by: jornvanwier <[email protected]>
Co-authored-by: Jorn van Wier <[email protected]>
Co-authored-by: Asif Saif Uddin <[email protected]>
Co-authored-by: Étienne Beaulé <[email protected]>
Co-authored-by: Sergei Shishov <[email protected]>
@acangiani
Copy link

@auvipy does this mean DRF supports Django 4.2? If so, can it be bundled into a new release? 3.14.0 was released more than 6 months ago.

@auvipy
Copy link
Collaborator

auvipy commented May 31, 2023

I just need response/permission for the release

@irtazaakram
Copy link

Hi @auvipy, Any updates on the release of the new version?

@auvipy
Copy link
Collaborator

auvipy commented Jun 12, 2023

Hi @auvipy, Any updates on the release of the new version?

not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants